Skip to content

Commit

Permalink
Move install-bundle script to dev-scripts directory (#1745)
Browse files Browse the repository at this point in the history
Related tiny-pilot/tinypilot-pro#1214

Based on our efforts to mitigate privilege escalation, the
`scripts/install-bundle` script was identified as being both
tinypilot-writeable and requiring root privileges. This PR moves the
script to the `dev-scripts/` directory.

<a data-ca-tag
href="https://codeapprove.com/pr/tiny-pilot/tinypilot/1745"><img
src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review
on CodeApprove" /></a>
  • Loading branch information
jdeanwallace committed Feb 15, 2024
1 parent 18c5bd1 commit 1916fb5
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ curl \
--silent \
--show-error \
--location \
https://raw.githubusercontent.com/tiny-pilot/tinypilot/master/scripts/install-bundle | \
https://raw.githubusercontent.com/tiny-pilot/tinypilot/master/dev-scripts/install-bundle | \
sudo bash -s -- \
url-to-bundle-file # replace this line with your bundle URL
```
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion dev-scripts/install-from-source
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,4 @@ mv "${LATEST_DEBIAN_PACKAGE}" ./bundler/bundle/
LATEST_INSTALL_BUNDLE="${PWD}/$(ls -t bundler/dist/tinypilot*.tgz | head -n 1)"
readonly LATEST_INSTALL_BUNDLE

sudo ./scripts/install-bundle "${LATEST_INSTALL_BUNDLE}"
sudo ./dev-scripts/install-bundle "${LATEST_INSTALL_BUNDLE}"

0 comments on commit 1916fb5

Please sign in to comment.