Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#90] Fix the session count in top_devices and top_browsers, using an… #91

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

alejandromav
Copy link
Member

Description

Using analytics_sessions_mv instead of analytics_sources_mv in the top_devices and top_browsers endpoints.

Another positive side effect is that those endpoint will perform better at scale, given the cardinality of analytics_sessions_mv is lower.

Fixes #90

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How Has This Been Tested?

I was able to reproduce this issue:

image

  • Test top_devices endpoint reports and accurate session count with the change
  • Same for top_browsers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have update the CHANGELOG
  • New and existing unit tests pass locally with my changes

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
analytics-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 5:06pm

Copy link
Contributor

@rmorehig rmorehig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the new endpoints and working as expected!

@alejandromav alejandromav merged commit 3cbe249 into main Sep 26, 2024
4 checks passed
@alejandromav alejandromav deleted the bugfix/90-fix-sessions-top-devices-browsers branch September 26, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The visits reported in top_devices and top_browsers endpoints may not be right
2 participants