-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: enable to customize OpenAI models #493
Conversation
Easydict/Swift/Feature/Configuration/Configuration+Defaults.swift
Outdated
Show resolved
Hide resolved
I just noticed that you created Please let me know what you think. |
I know, this code is ugly, but I just wanted to simply finish this PR. The main problem at the moment is that This part of the code needs to be refactored and optimized, but I'm not very familiar with SwiftUI, so if you'd like, we can open a separate issue later to refactor it, which will make it easier for subsequent feature, like #479 and #492 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please continue to review, code duplication will be resolved by this issue #497 . |
close #489