perf: enable built-in AI to set usage status and dict option #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
tisfeng
commented
Apr 28, 2024
tisfeng
commented
phlpsong
reviewed
Apr 28, 2024
|
I just refactored some code related to OpenAI, mainly allowing dynamic keys to be created based on the type of service, and then storing the configuration items for the service. This has reduced a lot of duplicated code. @phlpsong There is still room for further optimization in the code here, like |
|
I'm going to merge this PR, are there any questions? |
phlpsong
approved these changes
Apr 29, 2024
|
Nice work👍 I have been busy recently, I will schedule some time to take a look at these optimization issues later. |
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.