Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Polishing and Summary Features #609

Merged
merged 22 commits into from
Jul 16, 2024

Conversation

Jerry23011
Copy link
Collaborator

@Jerry23011 Jerry23011 commented Jul 12, 2024

closes #588
截屏2024-07-12 21 50 31

@Jerry23011 Jerry23011 changed the base branch from main to dev July 12, 2024 13:45
@tisfeng
Copy link
Owner

tisfeng commented Jul 13, 2024

I tried Summary and it didn't work very well.

First, it should answer in the user's first preferred language, e.g. if I set Chinese as my first preferred language, it should summarize in Chinese at this point.

Second, the summary is too long, the summary should be concise and clear, the prompt may need to be improved.

This is just an experiment to test the AI tool service, if Summary is not good, it's ok to only add Polishing.

56570 45802

@Jerry23011
Copy link
Collaborator Author

First, it should answer in the user's first preferred language

That's very true, I added Your summary should also be in \(sourceLanguage.queryLanguageName). in the prompts to explicitly tell the model to output the queryLanguage

Second, the summary is too long, the summary should be concise and clear, the prompt may need to be improved.

I added some examples for Chinese, hope it'll improve on performance for Chinese summary
截屏2024-07-13 18 57 25

@tisfeng
Copy link
Owner

tisfeng commented Jul 13, 2024

First, it should answer in the user's first preferred language, e.g. if I set Chinese as my first preferred language, it should summarize in Chinese at this point.

No, what I mean is, even if the source language of the text here is English, it should still be summarized in Chinese(first preferred language).

55231

@Jerry23011
Copy link
Collaborator Author

Even if the source language of the text here is English, it should still be summarized in Chinese

Can I add a toggle in settings to let users choose if they want to use the preferred language for the summary? I would expect for the summary to be the same as the source language.

@tisfeng
Copy link
Owner

tisfeng commented Jul 13, 2024

I think it would be better to answer these queries in the user's first preferred language, so that it is easier for users to look up any language they are not familiar with, not just Chinese or English。

For example I could use it to summarize articles in Ukrainian.

The same logic is currently used for Sentence and Dictionary, it would be better to keep it consistent.

48039

@tisfeng
Copy link
Owner

tisfeng commented Jul 13, 2024

For these unconventional AI tool services, it's better to set their usage status to alwaysOff by default, and only use them manually when needed 91ca4c0

@tisfeng
Copy link
Owner

tisfeng commented Jul 13, 2024

For AI services, prompts are very important.

These prompts may need further optimization later to achieve optimal results.

tisfeng
tisfeng previously approved these changes Jul 13, 2024
Copy link
Owner

@tisfeng tisfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Jerry23011
Copy link
Collaborator Author

For AI services, prompts are very important.

These prompts may need further optimization later to achieve optimal results.

I’ll look it up later and see how we can improve them

phlpsong
phlpsong previously approved these changes Jul 14, 2024
@tisfeng tisfeng dismissed stale reviews from phlpsong and themself via 0208daa July 14, 2024 04:34
@tisfeng
Copy link
Owner

tisfeng commented Jul 14, 2024

The icons for the Polishing and Summary services don't look very good, they seem to be too small and not clear, please check.

87209

@Jerry23011
Copy link
Collaborator Author

Jerry23011 commented Jul 14, 2024

The icons for the Polishing and Summary services don't look very good, they seem to be too small and not clear, please check.

Yes indeed, thanks for pointing out. Let me check it tonight

@Jerry23011
Copy link
Collaborator Author

The icons for the Polishing and Summary services don't look very good, they seem to be too small and not clear, please check.

Fixed with 72ccb48

@tisfeng
Copy link
Owner

tisfeng commented Jul 15, 2024

ok, polishing icon looks good now, but summary icon still looks unclear, are there any other alternatives?

54043

@Jerry23011
Copy link
Collaborator Author

They’re generated by DALL·E, let me try some new ones tomorrow

@Jerry23011
Copy link
Collaborator Author

I've added a new icon
截屏2024-07-16 14 51 28

@tisfeng
Copy link
Owner

tisfeng commented Jul 16, 2024

ok, looks good now.

@tisfeng tisfeng merged commit dafba90 into tisfeng:dev Jul 16, 2024
5 checks passed
@Jerry23011 Jerry23011 deleted the polishing-and-grammar branch July 18, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants