feat: change fixed window to be both default window #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tisfeng <tisfeng@gmail.com>
phlpsong
previously approved these changes
Jul 14, 2024
This reverts commit 8a7e71a.
AkaShark
previously approved these changes
Jul 14, 2024
|
I just pushed a wrong commit, already reverted it 🥲 |
AkaShark
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make Easydict easier to use and reduce confusion for new users, such as #565, I have decided to set the
fixedwindow as the default window, and both mouse selection and shortcut keys will use the fixed window by default.This PR will not affect existing users, and they can still choose to use either or both types of windows according to preference in the settings.