Add F_POINTED_AT; seems to work after some minimal testing #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titzer
reviewed
Nov 18, 2024
| @@ -329,7 +329,8 @@ class ReachabilityNormalizer(config: NormalizerConfig, ra: ReachabilityAnalyzer) | |||
| // add normalized field(s) to the vector | |||
| var tn = rf.typeNorm; | |||
| var facts = if(tn.size > 1, Fact.F_NORM, Facts.NONE); | |||
| if (!rf.raFacts.RF_WRITTEN) facts |= (Fact.F_VALUE | Fact.O_FOLDABLE); | |||
| if (!rf.raFacts.RF_WRITTEN && !rf.orig.facts.F_POINTED_AT) facts |= (Fact.F_VALUE | Fact.O_FOLDABLE); | |||
There was a problem hiding this comment.
Note I added this line while resolving a conflict here.
|
I've confirmed the CI fails because the additional fact brought the size of a |
|
On 11/19/2024 4:33 AM, Ben L. Titzer wrote:
I've confirmed the CI fails because the additional fact brought the size of a |Fact.set| over 32-bit, which seems to
have exposed some bugs in unboxing (that's why this only fails on the CI configurations that try to unbox all variants).
I'll try to get a repro and fix those other bugs. In the mean time, can you remove the unused |O_ASSOCIATIVE| case?
Yes - but do you mean in the PR or only locally? Eliot
|
In the PR. Since it only exposed a pre-existing bug (which I have a fix for, but not yet a smaller repro), no need to hold up this PR. |
|
On 11/19/2024 12:02 PM, Ben L. Titzer wrote:
Yes - but do you mean in the PR or only locally? Eliot
In the PR. Since it only exposed a pre-existing bug (which I have a fix for, but not yet a smaller repro), no need to
hold up this PR.
Change developed and added ... EM
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.