Small change to the aeneas script to make it more robust #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to weird setting by people like me
Sounds good, but it looks like the PR only contains a change to the aeneas script. |
|
Sigh -- yeah, wrong commit. I'm new to preparing PR's. I'll see about changing the title and content and then submitting the right PR! |
eliotmoss
changed the title
to weird setting by people like me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, blocks that start with a phi do not get optimized.
An interesting question is whether there are other things in a block, besides SsaApplyOp's, that should get skipped over (or otherwise handled) in the while loop. But this change was effective in removing junk from XXGetField's expanded in normalization from accesses to unboxed variants, at least in my test case. Your CI can check to see whether this causes any regressions ...