Allow for backspacing when entering a password #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: When typing into a prompt.password, if you were to make a typo and press delete to on your keyboard so that you could change it, it would just keep adding to the buffer as well as the process.stdout. After: The backspace keypress is caught, trimming the final character off the keypress, as well as not including it in the buffer.
|
works perfectly, but it doesn't remove the mask (*) character on the console, is this posible? |
|
Anyone planning to merge this soon? We're depending on it for a fix over at lambtron/emojipacks#72 :D |
|
This bug tho -_- , thanks for the pr dude. |
|
This really needs to be merged |
|
@OEMarshall dude, I would really give up on this and look into https://www.npmjs.com/package/prompts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: When typing into a prompt.password, if you were to make a typo and press delete to on your keyboard so that you could change it, it would just keep adding to the buffer as well as the process.stdout.
After: The backspace keypress is caught, trimming the final character off the keypress, as well as not including it in the buffer.