Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add poetry to handle the tests of the git extras #1121

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

vanpipy
Copy link
Collaborator

@vanpipy vanpipy commented Nov 30, 2023

Close #1102

Copy link
Collaborator

@hyperupcall hyperupcall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a single comment


The test part depends on:

* python >= 3.11
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should duplicate information be removed from the Testing section under the CONTRIBUTING.md?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya..I misremember the test content written before. I just wonder why i cannot find it 🤣

@spacewander spacewander merged commit 28b48c7 into tj:main Dec 1, 2023
5 checks passed
@vanpipy vanpipy deleted the feature/poetrible branch December 26, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discuss: add the python project attribute to git extras repository
3 participants