-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style-guide: recommend hyphen over en dash and em dash #15407
Conversation
I did a quick search over the current English pages. It seems like there were only four instances of en dashes or em dashes. Notably, the one in Usage seems to be more common in Cyrillic languages, but I'm not sure whether that's a tendency of the language or of the author. |
I opened a PR for |
@kbdharun I now see we do not check if a PR without any assigned reviewers is still in "Draft". This is why the labeler assigned "review needed" just yet. I would also let the labeler action run when we change a PR from "draft" to "ready for review". |
Co-authored-by: Wiktor Perskawiec <git@spageektti.cc> Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the nice addition.
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Continuing discussion in #15384 (comment).
@spageektti and I are in favour of hyphens in lieu of exceptional circumstances. I'd like to hear the opinions of other maintainers.