Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vectorstores: add Replacement option #1062

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

creeper12356
Copy link

vectorstores: add Replacement option

This PR introduce a Replacement member to the vectorstores options. This option can be used in AddDocuments function.
When Replacement is set to true, AddDocuments function will delete old record with the same Metadata attribute. (i.e to replace).
When Replacement is set to false (default case) , AddDocuments
function will simply add documents without checking existing
document records.

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

The changes introduce a `Replacement` member to the vectorstores
options. This option can be used in `AddDocuments` function.
When Replacement is set to `true`, AddDocuments function will
delete old record with the same Metadata attribute. (i.e to cover
or to replace).
When Replacement is set to `false`(default case), AddDocuments
function will simply add documents without checking existing
document records.
- add doc for `WithReplacement` opt
- add test in pgvector_test
@creeper12356 creeper12356 changed the title Add replacement opt vectorstores: add Replacement option Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant