Support printing IDs and selecting by ID #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- print JSON of id -> name - allow selection via id with -i
e.g. -i 904.4217
this saves complexity when reading/selecting - sort the metadata entries by the name tokens before writing - add an Idx field to the metadata struct
with either -l/--l=name
there are additional categories for each pokemon that I haven't dealt with until now. each cowfile has a path like - gen7x/regular/charizard.cow - gen7x/regular/charizard-mega-y.cow - gen7x/regular/charizard-mega-y.cow Everything after the first - in the basename is now parsed out into an extra category This makes the -l mode more transparent, and allows selection of cool stuff like shiny/mega etc.
TODO: clean and implement properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When using pokesay, it's possible to select a Pokemon's name and category, and then the final choice is made by randomly selecting between those.
This change gives each pokemon avatar a distinct ID so that an exact pokemon avatar can be selected
Command Line args
-l-I