Adding the correct floor ordinal in the welcome message #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmewett
approved these changes
Nov 26, 2023
| @@ -130,14 +130,34 @@ static void benchmark() { | |||
| printf("\n\nBenchmark took a total of %lu seconds.", ((unsigned long) time(NULL)) - initialTime); | |||
| } | |||
|
|
|||
| static const char *getOrdinalSuffix(int number) { | |||
There was a problem hiding this comment.
I thought returning char * was wrong but string literals have static duration so this is legit!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The welcome message previously assumed the Amulet of Yendor was on a -th floor. But, for example, in bullet brogue, it's on the 3-rd floor. This change supports all floor numbers.