Adding guarding on --print-seed-catalog so it won't exceed the deepestLevel #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flend
force-pushed
the
feature/guard_print_seeds_max_level
branch
2 times, most recently
from
39ccb5d
to
c4897b8
Compare
|
dont' really like the externing - couldn't we have printSeedCatalog do the validation and return an error code? |
flend
force-pushed
the
feature/guard_print_seeds_max_level
branch
2 times, most recently
from
1a519d1
to
4ad6758
Compare
|
Okay @tmewett I've reimplemented as you suggested. |
flend
force-pushed
the
feature/guard_print_seeds_max_level
branch
from
4ad6758
to
494a39b
Compare
|
ah forgot about the error message, this works though, tyvm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously --print-seed-catalog could exceed the max depth of shorter variants.
printSeedCatalognow returns anerrorCodeand writes to anerrorMessage.