fix: last check: multiple decls in one quantifier, minus operator RHS #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennn
reviewed
Feb 22, 2023
| (define one-more-decl (cons (assocify decl) sofar)) | ||
| (checkExpression run-or-state domain one-more-decl checker-hash) | ||
| one-more-decl)) | ||
| quantvars | ||
| decls) |
There was a problem hiding this comment.
Use the foldl output to define new-quantvars (below) instead of throwing it away.
bennn
reviewed
Feb 22, 2023
| ; CHECK: recur into domain(s) | ||
| (checkExpression run-or-state domain quantvars checker-hash))) | ||
| ; CHECK: recur into domain(s), carrying decls from prior quantifiers | ||
| (define one-more-decl (cons (assocify decl) sofar)) |
There was a problem hiding this comment.
Is to okay to put the decl at the front?
This is reverse order from the syntax & the new-quantvars below
|
This will be fixed in #247 as part of the AST testing improvements; closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) Quantifiers can contain multiple declarations. E.g.,
some x: A, y: B | ...However, since
AandBare arbitrary expressions,Bcan technically use the variablex. Our last-checker module does not currently add(x A)to the environment used for checking the expressionB, resulting in a confusing error. This PR rolls the expanded environment forward across all decl domains, from left to right.(2) Our last-checker module wasn't ever checking the right-hand side of a minus expression. Now if that exists, it's subjected to last-checker scrutiny.