Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Loggable[T].logShow to mask option fields noted with @masked #1237

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

NarekDW
Copy link
Contributor

@NarekDW NarekDW commented Apr 12, 2024

Let's say we have such a case class

  @derive(loggable)
  final case class MaskedOptBaz(
      @masked maybeStr: Option[String],
      @masked maybeInt: Option[Int],
      @masked maybeBool: Option[Boolean],
      @masked maybeDouble: Option[Double],
      @masked maybeStr2: Option[String]
  )

When I call the function

Loggable[MaskedOptBaz].logShow(maybeMasked)

Expectation:

MaskedOptBaz{maybeStr=Some(***),maybeInt=Some(###),maybeBool=Some(****),maybeDouble=Some(###.###),maybeStr2=<none>}

Actual behaviour:

MaskedOptBaz{maybeStr=str,maybeInt=123,maybeBool=true,maybeDouble=100.001,maybeStr2=<none>}

@NarekDW NarekDW force-pushed the fix-logShow-opt-values branch from a47bb0a to fdb1f7a Compare April 12, 2024 15:34
@FunFunFine FunFunFine merged commit 6c8f89d into tofu-tf:master Apr 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants