Use semver without 'v' for the wallet version (#484)

* Use semver without 'v' for the wallet version

* add Semver check for contract

* Ensure wallet version does not start with a v

contracts/wallet.sol

@@ -591,7 +591,7 @@ contract Wallet is ENSResolvable, Vault, GasTopUpLimit, LoadLimit {
     event ExecutedTransaction(address _destination, uint _value, bytes _data);
     event UpdatedAvailableLimit();
 
-    string constant public WALLET_VERSION = "v2.0.0";
+    string constant public WALLET_VERSION = "2.0.0";
     uint constant private _DEFAULT_MAX_STABLECOIN_LOAD_LIMIT = 10000; //10,000 USD
 
     /// @dev Is the registered ENS node identifying the licence contract.

go.mod

@@ -1,6 +1,7 @@
 module github.com/tokencard/contracts/v2
 
 require (
+	github.com/Masterminds/semver v1.4.2
 	github.com/ethereum/go-ethereum v1.8.27
 	github.com/kr/pretty v0.1.0 // indirect
 	github.com/onsi/ginkgo v1.6.0

go.sum

@@ -1,3 +1,5 @@
+github.com/Masterminds/semver v1.4.2 h1:WBLTQ37jOCzSLtXNdoo8bNM8876KhNqOKvrlGITgsTc=
+github.com/Masterminds/semver v1.4.2/go.mod h1:MB6lktGJrhw8PrUyiEoblNEGEQ+RzHPF078ddwwvV3Y=
 github.com/allegro/bigcache v1.1.1-0.20190116153254-84a0ff3f153c h1:JnxT952szw65TwPg7iz1iYVqEoikvX8mSkSgIhNr0Vo=
 github.com/allegro/bigcache v1.1.1-0.20190116153254-84a0ff3f153c/go.mod h1:Cb/ax3seSYIx7SuZdm2G2xzfwmv3TPSk2ucNfQESPXM=
 github.com/aristanetworks/goarista v0.0.0-20180907105523-ff33da284e76 h1:64W/KrGykPTfDI9xTkZtnjZRYA5p2+c/IuGgjzeWCpI=

test/wallet/wallet_suite_test.go

@@ -4,8 +4,10 @@ import (
 	"context"
 	"fmt"
 	"os"
+	"strings"
 	"testing"
 
+	"github.com/Masterminds/semver"
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/ethereum/go-ethereum/core/types"
 	. "github.com/onsi/ginkgo"
@@ -47,14 +49,27 @@ var _ = BeforeEach(func() {
 })
 
 var allPassed = true
-var currentVersion = "v2.0.0"
+var currentVersion = "2.0.0"
 
 var _ = Describe("Wallet Version", func() {
 	It("should return the current version", func() {
 		v, err := Wallet.WALLETVERSION(nil)
 		Expect(err).ToNot(HaveOccurred())
 		Expect(v).To(Equal(currentVersion))
 	})
+
+	It("should be a Semver", func() {
+		v, err := Wallet.WALLETVERSION(nil)
+		Expect(err).ToNot(HaveOccurred())
+		_, err = semver.NewVersion(v)
+		Expect(err).ToNot(HaveOccurred())
+	})
+
+	It("should not start with a v prefix", func() {
+		v, err := Wallet.WALLETVERSION(nil)
+		Expect(err).ToNot(HaveOccurred())
+		Expect(strings.HasPrefix(v, "v")).To(BeFalse())
+	})
 })
 
 var _ = AfterEach(func() {