Merge pull request #611 from tokencard/guard-gas-top-up

Add balance check for gas top up
tokencard · Sep 16, 2020 · ea5d68f · ea5d68f
2 parents b122bf7 + 47078b8
commit ea5d68f
Show file tree

Hide file tree

Showing 6 changed files with 43 additions and 4 deletions.
diff --git a/contracts/wallet.sol b/contracts/wallet.sol
@@ -662,6 +662,8 @@ contract Wallet is ENSResolvable, AddressWhitelist, SpendLimit, GasTopUpLimit, L
  /// @dev Refill owner's gas balance, revert if the transaction amount is too large
  /// @param _amount is the amount of ether to transfer to the owner account in wei.
  function topUpGas(uint256 _amount) external isNotZero(_amount) onlyOwnerOrController {
+ // Check contract balance is sufficient for the operation
+ require(address(this).balance > _amount, "balance not sufficient");
  // Check against the daily spent limit and update accordingly, require that the value is under remaining limit.
  _gasTopUpLimit._enforceLimit(_amount);
  // Then perform the transfer

diff --git a/pkg/bindings/mocks/isValidSignatureExporter.go b/pkg/bindings/mocks/isValidSignatureExporter.go