Allow querying of HTTP status codes for query and form rejections #2781
+22
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htrefil
changed the title
Turbo87
changed the title
Turbo87
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
This appears reasonable to me and matches the status() fn on the rejections in the axum package, which is automatically created by the macros in axum-core.
I think it would make sense to refactor these rejections to use the axum-core macros instead, but that is a larger refactoring and can be done in a follow-up pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
axum_extra::{query::QueryRejection, form::FormRejection}are missing a method that would allow users to query the status code without converting it into a response viaIntoResponsefirst.This is useful when one wants to customize rejection responses.
Solution
Add
pub fn status(&self) -> http::StatusCodemethods to both rejections.