use ManuallyDrop in Vec::from(bytes_mut)

tokio-rs · Mar 2, 2024 · 7bf4afd · 7bf4afd
1 parent cad19a6
commit 7bf4afd
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/bytes_mut.rs b/src/bytes_mut.rs
@@ -1617,6 +1617,7 @@ impl PartialEq<Bytes> for BytesMut {
 impl From<BytesMut> for Vec<u8> {
     fn from(bytes: BytesMut) -> Self {
         let kind = bytes.kind();
+        let bytes = ManuallyDrop::new(bytes);
 
         let mut vec = if kind == KIND_VEC {
             unsafe {
@@ -1633,7 +1634,7 @@ impl From<BytesMut> for Vec<u8> {
 
                 vec
             } else {
-                return bytes.deref().to_vec();
+                return ManuallyDrop::into_inner(bytes).deref().to_vec();
             }
         };
 
@@ -1644,8 +1645,6 @@ impl From<BytesMut> for Vec<u8> {
             vec.set_len(len);
         }
 
-        mem::forget(bytes);
-
         vec
     }
 }