impl From<Box<[u8; _]>> for Bytes #631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
force-pushed
the
bytes-from-sized-slice
branch
from
ab6656e
to
5c7b3f9
Compare
|
Thanks for the PR. Unfortunately, const generics is not available on bytes's minimum supported Rust version. |
|
@Darksonn Do you think we can bump the msrv? 1.51 is from March 2021, which was over 2 years ago. Happy to open a PR to do that as well |
|
It's not a blocker though; there are ways around it, I just think it's an ergonomy improvement :) |
|
Meh, I don't think this impl is enough justification to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that this implementation was missing when I needed it.