-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor split_at/split_to #663
Merged
Merged
Commits on Jan 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ea9dd60 - Browse repository at this point
Copy the full SHA ea9dd60View commit details
Commits on Jan 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 77a6f1c - Browse repository at this point
Copy the full SHA 77a6f1cView commit details -
The shallow clone call just above always results in the kind being shared so we don't need to assert it here.
Configuration menu - View commit details
-
Copy full SHA for 9bdf5eb - Browse repository at this point
Copy the full SHA 9bdf5ebView commit details -
we already assert this at the top of the method
Configuration menu - View commit details
-
Copy full SHA for 00a60eb - Browse repository at this point
Copy the full SHA 00a60ebView commit details -
remove redundant assertion and min
We know several things here: 1. self.len <= self.cap, always 2. at <= self.len, asserted at the top of this method 3. after calling shallow_clone, other.cap == self.cap Therefore, at <= self.len <= other.cap.
Configuration menu - View commit details
-
Copy full SHA for 00f2b20 - Browse repository at this point
Copy the full SHA 00f2b20View commit details -
rename set_start to advance_unchecked
This method never moves the cursor backward, only advances it forwards. I think reflecting that in the name makes things a bit more clear. I also added explicit safety comments to make it clear why each usage is sound.
Configuration menu - View commit details
-
Copy full SHA for 442f85d - Browse repository at this point
Copy the full SHA 442f85dView commit details
Commits on Feb 6, 2024
-
Merge branch 'master' of https://github.com/tokio-rs/bytes into split…
…-at-to-refactor
Configuration menu - View commit details
-
Copy full SHA for 037dbe1 - Browse repository at this point
Copy the full SHA 037dbe1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b971743 - Browse repository at this point
Copy the full SHA b971743View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.