Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to cargo dist for release publishing #522

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented Feb 13, 2024

No description provided.

@hawkw hawkw requested a review from a team as a code owner February 13, 2024 20:43
Copy link
Collaborator

@hds hds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using cargo dist is mostly about preparing binary distributions of tokio-console, right?

In that case, this looks good. I've been meaning to try release-plz for the actual release process as I think it might make that easier.

@hawkw
Copy link
Member Author

hawkw commented Feb 13, 2024

@hds:

Using cargo dist is mostly about preparing binary distributions of tokio-console, right?

Yeah, that's right; I haven't touched our existing script for updating changelogs and generating release tags. cargo-dist will just build lots of binaries, and also manage creating GitHub Releases (which is nice, because our current thing for that is broken...).

In that case, this looks good. I've been meaning to try release-plz for the actual release process as I think it might make that easier.

I believe cargo-dist integrates with cargo-release, which I think can do some of the other release prep stuff we're currently using the bash script for. But I haven't looked into that yet. I'm not familiar with release-plz and I don't really know how it compares with cargo-release, but I'm happy with any release automation we can add that works nicely with the way we're currently publishing stuff...the cargo-release/cargo-dist integration seems potentially appealing, but I'd need to look closer at it?

@hawkw hawkw merged commit 87026d9 into main Feb 13, 2024
16 checks passed
@hawkw hawkw deleted the eliza/cargo-dist branch February 13, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants