Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(subscriber): remove unused AggregatorHandle and fix other lints #578

Merged
merged 1 commit into from
Jul 29, 2024

Commits on Jul 29, 2024

  1. fix(subscriber): remove unused AggregatorHandle and fix other lints

    A number of new or updated Clippy lints in Rust 1.80.0 need to be fixed.
    
    An update to the `dead_code` pointed out that the `AggregatorHandle` is
    not used, and it is not constructable from outside the crate because it
    has a private field. This struct was introduced in #451 as part of the
    `Server::into_parts` method. Originally, this method was going to return
    the `AggregatorHandle`, which wrapped the join handle from the task
    where the `Aggregator` had been spawned. This was later replaced by
    returning the `Aggregator` itself, which the user had the obligation to
    spawn themselves. However, it seems that the `AggregatorHandle` wasn't
    removed, even though it was never used.
    
    A new lint is the one for unexpected `--cfg` items. We now need to
    declare those in `Cargo.toml`.
    
    An update to `needless_borrows_for_generic_args` causes a false positive
    changing a `&mut` to a move, which we can't do as the same value is used
    afterwards.
    hds committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    864a481 View commit details
    Browse the repository at this point in the history