Some edits for Tutorial: Shared State #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved Tasks, threads and contention to the end:
- This is deeper and more detailed than the previous sections
- Also, the part on restructuring the code should be higher up
- Added more warnings on Send Guards.
- Linking to Alice Ryhl's post twice, both segments seem to benefit
from this link.
This PR has some "quick fixes", that I believe would be helpful for
tokio users at large.
The best thing we could do I believe, however, would be to sanitize
the examples, so that all the example code would have wrapped mutexes
only, making it much less likely for tokio users to end up with
problematic code.
hds
reviewed
Jul 2, 2024
Co-authored-by: Hayden Stainsby <hds@caffeineconcepts.com>
Co-authored-by: Hayden Stainsby <hds@caffeineconcepts.com>
hds
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has some "quick fixes", that I believe would be helpful for tokio users at large.
The best thing we could do I believe, however, would be to sanitize the examples, so that all the example code would have wrapped mutexes only, making it much less likely for tokio users to end up with problematic code.