Fix inability to handle files with a trailing newline #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for json arrays in the stub files was added previously, but it only worked with array files that did not end with a newline or files only containing a single non-array stub definition. Since all files written on linux will typically end in a newline this PR adds a rudimentary input sanitisation step while reading the file which fixes this. Also tidy up some deprecations and add some more helpful error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for json arrays in the stub files was added previously, but it only worked with array files that did not end with a newline or files only containing a single non-array stub definition. Since all files written on linux will typically end in a newline this PR adds a rudimentary input sanitisation step while reading the file which fixes this.
Also tidy up some deprecations and add some more helpful error messages.