fix: load error messages for batch jobs when they fail

tolgee · Jun 27, 2024 · dd88764 · dd88764
1 parent 1a06645
commit dd88764
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/webapp/src/hooks/ProjectContext.tsx b/webapp/src/hooks/ProjectContext.tsx
@@ -78,8 +78,10 @@ export const [ProjectContext, useProjectActions, useProjectContext] =
 
     const changeHandler = ({ data }: BatchJobProgress) => {
       const exists = batchOperations?.find((job) => job.id === data.jobId);
+      let shouldRefetch = false;
       if (!exists) {
         if (!knownJobs.includes(data.jobId)) {
+          shouldRefetch = true;
           // only refetch jobs first time we see unknown job
           setKnownJobs((jobs) => [...jobs, data.jobId]);
           setBatchOperations((jobs) => [
@@ -92,12 +94,15 @@ export const [ProjectContext, useProjectActions, useProjectContext] =
               errorMessage: data.errorMessage,
             },
           ]);
-          batchJobsLoadable.refetch();
         }
       } else {
         setBatchOperations((jobs) =>
           jobs?.map((job) => {
             if (job.id === data.jobId) {
+              if (data.status === 'FAILED' && data.status !== job.status) {
+                // load error message
+                shouldRefetch = true;
+              }
               return {
                 ...job,
                 totalItems: data.total ?? job.totalItems,
@@ -110,6 +115,9 @@ export const [ProjectContext, useProjectActions, useProjectContext] =
           })
         );
       }
+      if (shouldRefetch) {
+        batchJobsLoadable.refetch({ fetching: true });
+      }
     };
 
     const changeHandlerRef = useRef(changeHandler);