-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Cockroach DB support #1405
base: main
Are you sure you want to change the base?
Conversation
Cockroach has a bunch of recommendations for CI envs, it may be interesting in looking into them to speed up CI which seem awfully slow looking at GitHub action reports https://www.cockroachlabs.com/docs/stable/local-testing.html |
Let's wait for https://github.com/cockroachdb/cockroach/milestone/28 |
TM works fine with CRDB v22.2-beta.4! |
we are running it now with CRDB v22.2.0 :) looking forward to see this merged, thanks again for implementing it! |
Hey! I still have to fix all the tests 😢 I've updated the crdb to the stable, so lets see. |
XD sry, completely missed that. Perhaps I will find time towards the end of the week to help. |
36f74e9
to
866f2af
Compare
…saction in listener
UPDATE: I fixed the tests in this repo. However, we have another private repo, where we work on pricing/billing section of the app. And in this repo I cannot get it working, since there is some weird stuff related to transactions happening. UPDATE 2: I fixed the private repo issues, but now there is 7 failing tests in this repo. I am out of time budget I want to invest to this, so I will try again later again. If someone would like to contribute in this, the tests can be run with cockroachDB with
Single test can be run and debugged in IntelliJ Idea CE or Ultimate. Just use gradle runner and set the environment env. Anyway... We are currently going to move our production to MS Azure and their Cosmos for Postgres, since that is more stable for now. Will consider Cockroach later, when we're stabilized. |
This PR is stale because it has been open for 30 days with no activity. |
This PR is stale because it has been open for 30 days with no activity. |
This PR is stale because it has been open for 30 days with no activity. |
This PR is stale because it has been open for 30 days with no activity. |
@stepan662 Why it went stale? It's tagged as |
@JanCizmar Because on PRs, it checks only for "keep-open" label. On issues, it checks "roadmap item, enhancement, keep-open, bug". |
There are some issues which have to be fixed: