feat: Update to Spring Boot 3, stabilize, project & organization delete performance (soft deleting) #1938

JanCizmar · 2023-10-10T07:34:03Z

No description provided.

cyyynthia

Gave a quick look, changes to security config seem all good to me. I didn't look at everything in detail but I picked up some nitpicks that were worth writing down 😅

cyyynthia · 2023-10-30T12:18:27Z

.github/workflows/test.yml

@@ -30,6 +30,9 @@ jobs:
            ~/.gradle/wrapper
          key: ${{ runner.os }}-gradle-wrapper-${{ hashFiles('gradle/wrapper/gradle-wrapper.properties') }}

+      - name: Compile kotlin
+        run: ./gradlew compileTestKotlin --parallel


When I tried making CI faster the other day doing this I recall it turned out to significantly increase the time it took to do the initial build job without a clear speed gain on the test run jobs, making everything overall slower. 🤷🏻‍♀️

cyyynthia · 2023-10-30T12:21:16Z

backend/api/src/main/kotlin/io/tolgee/api/v2/controllers/KeyController.kt

+  }
+
+  private fun List<Language>.toViews(): List<LanguageViewImpl> {
+    val baseLanguage = projectHolder.projectEntity.baseLanguage


Couldn't the base language be cached too to avoid pulling the entity from database?

cyyynthia · 2023-10-30T12:29:42Z

backend/data/src/main/kotlin/io/tolgee/service/LanguageService.kt

  fun deleteAllByProject(projectId: Long) {
-    findAll(projectId).forEach {
-      deleteLanguage(it.id)
-    }
+    translationService.deleteAllByProject(projectId)
+    autoTranslationService.deleteConfigsByProject(projectId)
+    entityManager.createNativeQuery(
+      "delete from language_stats " +
+        "where language_id in (select id from language where project_id = :projectId)"
+    )
+      .setParameter("projectId", projectId)
+      .executeUpdate()
+    entityManager.createNativeQuery("DELETE FROM language WHERE project_id = :projectId")
+      .setParameter("projectId", projectId)
+      .executeUpdate()
  }


Shouldn't this belong to repository-level logic?

cyyynthia · 2023-10-30T12:45:20Z

backend/data/src/main/kotlin/io/tolgee/service/InvitationService.kt

@@ -204,7 +205,9 @@ class InvitationService @Autowired constructor(
  }

  fun getForOrganization(organization: Organization): List<Invitation> {
-    return invitationRepository.getAllByOrganizationRoleOrganizationOrderByCreatedAt(organization)
+    return traceLogMeasureTime("get invitations for organization") {


Is this intentionally left here?

Yeah, why not :)

# [3.41.0](v3.40.0...v3.41.0) (2023-12-15) ### Features * Update to Spring Boot 3, stabilize, project & organization delete performance (soft deleting) ([#1938](#1938)) ([3147302](3147302))

github-actions · 2023-12-15T08:45:23Z

🎉 This PR is included in version 3.41.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

JanCizmar changed the title ~~fix: Disable open in view, update tomcat~~ fix: Update to Spring 3, stabilize Oct 10, 2023

JanCizmar mentioned this pull request Oct 10, 2023

AnnotationScanner scanning leads to StackOverflowError with recursive annotation spring-projects/spring-framework#31400

Closed

JanCizmar force-pushed the jancizmar/stabilize branch 2 times, most recently from 3424625 to 36f3416 Compare October 20, 2023 17:10

JanCizmar force-pushed the jancizmar/stabilize branch 2 times, most recently from 98967e7 to 9092afc Compare October 27, 2023 14:12

cyyynthia reviewed Oct 30, 2023

View reviewed changes

JanCizmar force-pushed the jancizmar/stabilize branch from 45e8d1a to 87cb59f Compare October 30, 2023 13:07

JanCizmar force-pushed the jancizmar/stabilize branch from e983ca8 to 844659f Compare November 20, 2023 15:53

JanCizmar changed the title ~~fix: Update to Spring 3, stabilize~~ fix: Update to Spring Boot 3 Nov 21, 2023

JanCizmar marked this pull request as draft November 24, 2023 14:07

JanCizmar force-pushed the jancizmar/stabilize branch 2 times, most recently from 0e3ac1e to 0424c51 Compare December 7, 2023 12:39

JanCizmar force-pushed the jancizmar/stabilize branch 2 times, most recently from e1eae09 to f8ff623 Compare December 12, 2023 15:10

JanCizmar added 15 commits December 14, 2023 14:00

fix: Disable open in view, update tomcat

4b8102a

fix: Revert update tomcat

fa4174c

fix: Try to update to Spring 3

f7d0947

fix: Upgrade to Spring 3: compiles

9dfe18d

fix: Upgrade to Spring 3: fix some issues

cf88e5b

fix: Upgrade to Spring 3: runs

1383f09

fix: Upgrade to Spring 3: runs and works

14c1ead

fix: Enable open-in-view again

2543fd5

fix: It builds, formatted

f48caea

fix: Some BO tests

39b9892

fix: Activity interceptors

ede4be3

fix: The export

6b4104a

fix: Migrate batch, dockerfile

dd16d50

fix: Update hibernate types, fix dockerfile

7e904eb

fix: Upgrade Java and Postgres in Docker

69511f2

JanCizmar added 13 commits December 14, 2023 14:03

chore: fix E2E test

6d7369b

chore: try older ubuntu runner

d71a60e

chore: Minor improvements & fixes

07955fc

chore: Minor improvements & fixes

01562f6

chore: Minor improvements & fixes

570095b

chore: Minor improvements & fixes

d19ae16

chore: Minor improvements & fixes

2c187d0

chore: Fix possible dead lock in E2E test using higher isolation level

d6ca63e

chore: Try to increase timeout on the clean

2540d21

chore: More fixes

44c00a9

chore: Minor performance improvements

f412ddd

chore: Startup time improvements

9db4216

fix: Weird Async Dispatching messages

7d9cd1b

JanCizmar force-pushed the jancizmar/stabilize branch from ff42e56 to 7d9cd1b Compare December 14, 2023 13:06

JanCizmar added 9 commits December 14, 2023 14:43

fix: Fix rebasing issues

e6f0101

chore: Fix inital user creation and PAT tests

7764e36

chore: Optimize test startup time

7fd3f87

fix: Demo project creation

c9d3c3b

fix: More tests & ktlint

afb9c99

fix: bypass the language stats listener in tests

5e63916

fix: Update test assertions and exception handling

bb1d149

fix: Update SQL query in CurrentDateProvider

53464b5

chore: Update database connection pool test

cbbdd77

JanCizmar changed the title ~~fix: Update to Spring Boot 3~~ feat: Update to Spring Boot 3, stabilize, project & organization delete performance (soft deleting) Dec 14, 2023

JanCizmar marked this pull request as ready for review December 15, 2023 08:21

JanCizmar merged commit 3147302 into main Dec 15, 2023
28 checks passed

JanCizmar deleted the jancizmar/stabilize branch December 15, 2023 08:21

github-actions bot added the released on @latest label Dec 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Update to Spring Boot 3, stabilize, project & organization delete performance (soft deleting) #1938

feat: Update to Spring Boot 3, stabilize, project & organization delete performance (soft deleting) #1938

JanCizmar commented Oct 10, 2023

cyyynthia left a comment

cyyynthia Oct 30, 2023

cyyynthia Oct 30, 2023

cyyynthia Oct 30, 2023

cyyynthia Oct 30, 2023

JanCizmar Nov 21, 2023

github-actions bot commented Dec 15, 2023

feat: Update to Spring Boot 3, stabilize, project & organization delete performance (soft deleting) #1938

feat: Update to Spring Boot 3, stabilize, project & organization delete performance (soft deleting) #1938

Conversation

JanCizmar commented Oct 10, 2023

cyyynthia left a comment

Choose a reason for hiding this comment

cyyynthia Oct 30, 2023

Choose a reason for hiding this comment

cyyynthia Oct 30, 2023

Choose a reason for hiding this comment

cyyynthia Oct 30, 2023

Choose a reason for hiding this comment

cyyynthia Oct 30, 2023

Choose a reason for hiding this comment

JanCizmar Nov 21, 2023

Choose a reason for hiding this comment

github-actions bot commented Dec 15, 2023