Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add simple properties file importer #2050

Merged
merged 4 commits into from
Dec 28, 2023
Merged

feat: Add simple properties file importer #2050

merged 4 commits into from
Dec 28, 2023

Conversation

benallard
Copy link
Contributor

@benallard benallard commented Dec 28, 2023 •
edited
Loading

See #2042

@JanCizmar
Copy link
Contributor

Hey! Thanks a lot for the PR! It would be great to have some tests and add the support also to front-end? Are you open to do it as well? 🚀

@JanCizmar JanCizmar changed the title Add a rather rudimentary properties file importer. feat: Add simple properties file importer Dec 28, 2023
@benallard
Copy link
Contributor Author

By front-end support, you mean extending the text on the page ?

And about the tests, can you point me to some related ones that can inspire me?

Thanks.

@JanCizmar
Copy link
Contributor

By front-end support, you mean extending the text on the page ?

Yes. I forgot, there is actually no front-end validation for selected files extension. So extending the text should do it. Which is hard coded in Tolgee (unfortunately), so I will fix it later.

And about the tests, can you point me to some related ones that can inspire me?

io.tolgee.unit.service.dataImport.processors.processors.po.PoParserTest

This one should do it.

@benallard
Copy link
Contributor Author

Both points have been addressed. Thanks!

@JanCizmar JanCizmar self-requested a review December 28, 2023 12:01
@JanCizmar
Copy link
Contributor

Huh, there is some issue with the test reporting task... Merging it anyway...

@JanCizmar JanCizmar merged commit 11dd90f into tolgee:main Dec 28, 2023
22 of 28 checks passed
TolgeeMachine pushed a commit that referenced this pull request Dec 28, 2023
@semantic-release-bot
chore(release): 3.43.0 [skip ci]
ac147eb 
# [3.43.0](v3.42.7...v3.43.0) (2023-12-28)

### Features

* Add simple properties file importer ([#2050](#2050)) ([11dd90f](11dd90f)), closes [#2042](#2042)
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 3.43.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanCizmar JanCizmar JanCizmar approved these changes

Assignees
No one assigned
Labels
released on @latest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benallard @JanCizmar @allardbe-sla