fix: single-step-import lack of auto-translation #2446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balk-sp
changed the title
|
Hey! Thanks for the PR. The AutoTranslation is handled by this listener: |
|
Oh! Maybe it's because single step import doesn't have |
|
I've fixed it here: #2447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The auto-translation step is not executed after single-step-import, when the project is configured to have auto-translation executed on import.
Solution
The PR is functional, but may not be in line with the event triggering/handling of Tolgee.
It may be possible that this PR can be boiled down to 1 line: firing the correct Event.