feat: Export description as comment for Android #2472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaclavsauer
commented
Sep 19, 2024
| "I am not just a percent {name} % sign!", | ||
| keyName = "percent and placeholders", | ||
| text = "I am not just a percent {name} % sign!", | ||
| description = "This is a description", |
There was a problem hiding this comment.
had to do this this way insted of
{
key.description = "Description"
}
Is it OK?
See additional change in ExportTranslationView
backend/data/src/main/kotlin/io/tolgee/service/export/dataProvider/ExportTranslationView.kt
Show resolved
Hide resolved
JanCizmar
requested changes
Sep 19, 2024
| @@ -23,8 +23,9 @@ class AndroidXmlFileExporterTest { | |||
| |<resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2"> | |||
| | <string name="key1">Ahoj! I%d, %s, %e, %f</string> | |||
| | <string name="percent_no_placeholders">I am just a percent \% sign!</string> | |||
| | <string name="percent_and_paceholders">I am not just a percent %s %% sign!</string> | |||
| | <string name="percent_and_paceholders_and_tags"><![CDATA[I am not just a percent <b>%s</b> %% sign!]]></string> | |||
| | <!--This is a description--> | |||
There was a problem hiding this comment.
You're testing only the plain string comment, but not plural and string array item.
| @@ -25,6 +21,10 @@ class AndroidStringsXmlFileWriter(private val model: AndroidStringsXmlModel) { | |||
| private fun Element.addToElement(unit: Map.Entry<String, AndroidXmlNode>) { | |||
| when (val node = unit.value) { | |||
| is StringUnit -> { | |||
| val comment = node.comment | |||
| if (!comment.isNullOrEmpty()) { | |||
There was a problem hiding this comment.
It wold be great to Create a private extension function Element.comment, which will add the comment only if it's not null to remove the deduplicate the duplicated null checking logic.
|
Superseded by #2560 |
Anty0
added a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #2391
I'm not sure if tests are OK. A lot of them failed because there is a difference in line endings on windows.