Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Respect project.icuPlaceholders in singleStepImport #2629

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix: Respect project.icuPlaceholders in singleStepImport #2629

merged 1 commit into from
Oct 29, 2024

Conversation

Anty0
Copy link
Collaborator

@Anty0 Anty0 commented Oct 25, 2024

Fixes #2574

@Anty0 Anty0 mentioned this pull request Oct 25, 2024
Closed
@Anty0
Copy link
Collaborator Author

Anty0 commented Oct 25, 2024

I wanted to create a test for the issue but didn't find a good place for it. We test the underlying import mechanics, but the actual API is tested by E2E tests. Since the FE doesn't use the single-step import, I don't see an easy way to test that API endpoint. Do you have any ideas, @JanCizmar?

@Anty0 Anty0 requested a review from JanCizmar October 25, 2024 13:55
@JanCizmar JanCizmar merged commit 5e2b72a into main Oct 29, 2024
29 checks passed
@JanCizmar JanCizmar deleted the jirikuchynka/single-step-import-respect-project-icu-enabled branch October 29, 2024 09:57
TolgeeMachine pushed a commit that referenced this pull request Oct 29, 2024
@semantic-release-bot
chore(release): 3.80.5 [skip ci]
09b80ee 
## [3.80.5](v3.80.4...v3.80.5) (2024-10-29)

### Bug Fixes

* Avoid requesting super auth when authentication is disabled ([#2630](#2630)) ([3f7919a](3f7919a))
* Respect project.icuPlaceholders in singleStepImport ([#2629](#2629)) ([5e2b72a](5e2b72a)), closes [#2574](#2574)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanCizmar JanCizmar Awaiting requested review from JanCizmar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tolgee doesn't parse ruby yaml correctly for some cases
2 participants
@Anty0 @JanCizmar