Skip to content

Commit

Permalink
Merge pull request #371 from jdegand/typos-3
Browse files Browse the repository at this point in the history
fix: Typos 3
  • Loading branch information
tomalaforge authored Nov 25, 2023
2 parents 5739279 + 3e68643 commit 36ad018
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion docs/src/content/docs/challenges/angular/32-bug-cd.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ The goal of the challenge is to debug this application and make it work.
<details>
<summary>Hint 1</summary>

If you comment out `routerLinkActive="isSelected"` inside `NavigationComponent`: the application loads correctly.
If you comment out `routerLinkActive="isSelected"` inside `NavigationComponent`, the application loads correctly.
</details>

<details>
Expand Down
2 changes: 1 addition & 1 deletion docs/src/content/docs/challenges/angular/33-decoupling.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ WIP: The following documentation will be reviewed and improved. However, you can

The goal of this challenge is to separate the behavior of a component from its style. For the purpose of this challenge, we will be working on a button element. When we click on it, we will toggle a _disabled_ property which will change the style of the element. This is quite useless in real life but the challenge aims to demonstrate a useful concept.

The behavior of the component (referred to as the _brain_ in the Spartan stack) is located in the brain library. The styling part (referred to as the _helmet_) is located inside the helmet library. Both libraries cannot depend on each other because we want to be able to publish them separately. To help us address the issue, we are using the Nx enforce eslint rule. You can find more details [here](https://nx.dev/core-features/enforce-module-boundaries);
The behavior of the component (referred to as the _brain_ in the Spartan stack) is located in the brain library. The styling part (referred to as the _helmet_) is located inside the helmet library. Both libraries cannot depend on each other because we want to be able to publish them separately. To help us address the issue, we are using the Nx enforce eslint rule. You can find more details [here](https://nx.dev/core-features/enforce-module-boundaries).

However the button's helmet needs to access the state of the component to style the button differently based on its state. As mention above, we cannot import the `BtnDisabledDirective` directly into the helmet library as done currently. If you go to [`BtnHelmetDirective`](../../libs/decoupling/helmet/src/lib/btn-style.directive.ts), you will encounter a linting error. **A project tagged with `type:hlm` can only depend on libs tagged with `type:core`**.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ However the context of **NgTemplateOutlet** type is **Object**. But with the hel

## Statement

In this exercice, we want to learn how to strongly typed our ng-template in our AppComponent.
In this exercice, we want to learn how to strongly type our ng-template in our AppComponent.

This exercice has two level of complexity.
This exercice has two levels of complexity.

### Level 1: known Interface

Expand Down
2 changes: 1 addition & 1 deletion docs/src/content/docs/challenges/angular/6-permissions.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ In LoginComponent, you will find 6 buttons corresponding at 6 differents users.

## Step 1

In **InformationComponent**, display the correct piece of information for each roles.
In **InformationComponent**, display the correct piece of information for each role.

### Constraints:

Expand Down
8 changes: 4 additions & 4 deletions docs/src/content/docs/challenges/ngrx/7-power-effect.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ WIP: The following documentation will be reviewed and improved. However, you can

## Information

NgRx Effect is a very powerful library develop by the NgRx team. Effects subscribe to a HOT Observable and listen to any event dispatch from any place inside the application.
NgRx Effect is a very powerful library developed by the NgRx team. Effects subscribe to a HOT Observable and listen to any event dispatched from any place inside the application.

But what we often forget is that Effects can subscribe to ANY observables. Which means we can wrap a hot observable inside an effect and had logic in it.
But what we often forget is that Effects can subscribe to ANY observable. Which means we can wrap a hot observable inside an effect and had logic in it.

In this exercice, we will find a way to create a very powerful, scalable and maintanable push messages listener. Currently, the code is located inside a single file with a if else condition to send the push data to the right location. This code is not very scalable since we need to add more and more else, and so not very maintainable since the piece of code will become bigger and bigger.

Expand All @@ -28,9 +28,9 @@ create an injection token to hide the push service implementation.

### Step 2

create one ngrx effect, or component store effect for each push type, and implement your logic
create one ngrx effect, or component store effect for each push type, and implement your logic.

### Step 3

load your effect only when necessary.
the application contain a root route, a lazy loaded route and a component with a local state (implemented with Component store)
the application contain a root route, a lazy loaded route and a component with a local state (implemented with Component store).

0 comments on commit 36ad018

Please sign in to comment.