Answer: 43 #1149
Closed
Answer: 43 #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
43
tomalaforge
reviewed
Nov 17, 2024
| export class UserComponent { | ||
| readonly name = input.required<string>(); | ||
| readonly lastName = input<string>(''); | ||
| readonly age = input<string>(''); |
There was a problem hiding this comment.
you can add a transform method to make it a number with a default value to 0
tomalaforge
reviewed
Nov 17, 2024
| this.fullName = `${this.name} ${this.lastName ?? ''}`; | ||
| this.category = ageToCategory(Number(this.age) ?? 0); | ||
| } | ||
| readonly fullName = computed(() => `${this.name()} ${this.lastName() ?? ''}`); |
There was a problem hiding this comment.
you don't need the ?? '', lastName has a default value.
tomalaforge
reviewed
Nov 17, 2024
| 10: 'Youth', | ||
| 18: 'Junior', | ||
| 35: 'Open', | ||
| }; |
There was a problem hiding this comment.
Why not putting this const outside of the scope of the function, so you don't recreate it at each call.
|
nice work |
|
This pull request is stale because it has been open for 15 days with no activity. |
|
This pull request was closed because it has been inactive for 5 days since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for challenge submission
Warning:
Alternatively, you can still submit your PR to join the list of answered challenges or to be reviewed by a community member. 🔥