Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Docker build and GHA test of container #34

Merged
merged 35 commits into from
Mar 1, 2024

Conversation

tomaroberts
Copy link
Owner

@tomaroberts tomaroberts commented Feb 20, 2024

PR adds:

  • Dockerfile to build nii2dcm
  • GHA which tests the build on PR

TODO:

  • do not merge until updated Dockerfile with pip install PyPI version
  • add Docker section to README
  • push container to GHCR

@tomaroberts
Copy link
Owner Author

Tests fine, failed because of TestPyPI timeout.

Copy link

github-actions bot commented Mar 1, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
nii2dcm
   __main__.py34340%5–68
   dcm.py93298%165–166
   dcm_writer.py33682%89–95
   nii.py35294%34–35
   run.py30293%57, 66
   utils.py770%8–36
nii2dcm/modules
   mr_image.py59297%39–40
TOTAL4315587% 

Tests Skipped Failures Errors Time
18 0 💤 0 ❌ 0 🔥 4.993s ⏱️

Copy link

github-actions bot commented Mar 1, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
nii2dcm
   __main__.py34340%5–68
   dcm.py93298%165–166
   dcm_writer.py33682%89–95
   nii.py35294%34–35
   run.py30293%57, 66
   utils.py770%8–36
nii2dcm/modules
   mr_image.py59297%39–40
TOTAL4315587% 

Tests Skipped Failures Errors Time
18 0 💤 0 ❌ 0 🔥 4.925s ⏱️

@tomaroberts tomaroberts marked this pull request as ready for review March 1, 2024 16:21
@tomaroberts tomaroberts merged commit b2386e5 into dunamai-production-fix Mar 1, 2024
3 checks passed
@tomaroberts tomaroberts deleted the docker-build branch March 1, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant