Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation Advanced Search #175

Closed
wants to merge 4 commits into from

Conversation

CachingFoX
Copy link
Contributor

@CachingFoX CachingFoX commented Dec 5, 2021

The PR provides an interface to the advanced search of www.geocaching.com. The new method can be use the full power of advanced search.

Features

  • Powerful search with a lot of filters
  • Results are sortable (asc and desc)
  • Limit number of returned caches
  • Solve issue Searching for user hides #148 (caches owned by an users)
  • Old search method still exists and use internally the new one
  • Full usage of AJAX endpoint

Known Limitations, Problems Bugs

  • Works only with the English website (for multi language support I18N helper from Get country and state from a cache #170 required)
  • There is not hint in the AJAX response if a search options is only available for PM users. GS perform a normal search :-/

@CachingFoX CachingFoX marked this pull request as draft December 5, 2021 16:39
@aleung
Copy link

aleung commented Aug 5, 2022

Any progress on this PR? Looking forward to it.

@BelKed
Copy link
Contributor

BelKed commented Jan 9, 2023

Hi @CachingFoX 👋

I hope you're doing well. I was wondering if you had any updates on this PR. I also wanted to let you know that I was able to get the feature working in my fork.

I would appreciate it if you could try to finish this PR as soon as possible. I don't want to see this awesome feature get left out of the master branch.

If it's okay with you, I'd like to help finish the PR. I'll check back in a month to see if you have had a chance to consider my request and provide a response.

Thanks in advance for your help and consideration :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants