Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for version 2023-11-03 #89

Merged
merged 2 commits into from
Nov 15, 2023
Merged

support for version 2023-11-03 #89

merged 2 commits into from
Nov 15, 2023

Conversation

catriona-m
Copy link
Collaborator

@catriona-m catriona-m commented Nov 15, 2023

Fixes #67

Copy link
Owner

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment around the examples, which I think wants to be split into it's own PR given this needs to be done in the other API version too - but otherwise LGTM 👍

@@ -0,0 +1,57 @@
## Blob Storage Account SDK for API version 2020-08-04
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst the examples need updating to account for this API version, they also need updating to use the updated SDK - as such can we update these but in a separate PR / as a part of fixing #73?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking the same - do you want me to remove them completely from this PR or fix them up in the next one with the rest of the readmes?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, fixing this up in the next one makes sense, let's merge this for now then 👍

@tombuildsstuff tombuildsstuff merged commit 8bee545 into main Nov 15, 2023
1 check passed
@tombuildsstuff tombuildsstuff deleted the storage2023-11-03 branch November 15, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for API Version 2023-11-03
2 participants