-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contextual Sidebars Module, Grouping, Deterministic Colour Generation #454
Open
timothycdc
wants to merge
38
commits into
tomcl:master
Choose a base branch
from
timothycdc:tdc21_select_ui
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs more checking
Overcomplicated draft selection UI. will port this to DevMode
Overcomplicated draft selection UI. will port this to DevMode
…into tdc21_select_ui
Overcomplicated draft selection UI. will port this to DevMode
Overcomplicated draft selection UI. will port this to DevMode
…into tdc21_select_ui
- Handle deletion of symbols by also deleting them from groups (symbolUpdate) - try to use more granular SymbolT.Model instead of SheetT.Model where possible - Contextual Sidebar has dynamic title text and classes - Improved comments all around - Current issues: phantom groups when changing sheets / groups are not saved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add functionality to set 'groups of symbols', used for HLP25. Also adds a deterministic colour generator for groups, using poisson-disk sampling for distantly-spaced colours that do not clash with existing UI colours.
This feature also introduces a UI library for a 'contextual sidebar' that can be programmatically called and accept user input via buttons or dialog, and modify the model in turn. One key example of a sidebar is the group selection sidebar, shown below.
Developer Mode
Contextual Sidebars
dispatch
and have the ability to modify the existing modelGroup Selection Sidebar
SymbolT.Model
Groups.fs
to create new groups, add symbols to a group, delete symbols from a group, and delete whole groups.Screenshots
Type Defs:
Other notes/current issues: