fixed add_connection method #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faizan-nexyom
approved these changes
Nov 1, 2024
pankajToday
reviewed
Nov 2, 2024
dino-exela
approved these changes
Nov 2, 2024
tomquirk
requested changes
Nov 3, 2024
There was a problem hiding this comment.
Hey @yashdharme thanks for this contribution and concise PR! Just left one comment 🙏 . Could you please also run poetry run black . for formatting?
Done. Can you please check and revert? |
Done. Please check and revert back if further changes are required. |
|
Hi everyone! can we merge this PR?? we need add_connection! 🥶 |
|
Thank you @yashdharme ! Let's merge 🏁 |
tomquirk
approved these changes
Nov 7, 2024
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
add_connectionfunction to align with the new endpoint and revised payload requirements for sending connection requests, in reference to Issue #448.Testing:
Please review the changes and let me know if any further modifications are needed!