UI for custom tokens for Stamen/Stadia maps #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strictly speaking this is a breaking change as it requires mroe recent versions of Xcode
|
Thanks @paulschuberth, this looks like a great start. I think we'd need to do a few things to make this suitable for normal users:
I appreciate that might be biting off more than you want to on this! |
|
Very valid points! I am happy to give it a try and will update here, once I have something I think is worth reviewing again 👍🏻 |
paulschuberth
force-pushed
the
allow-custom-tokens
branch
from
87cf59c
to
44323c3
Compare
|
Hi @tomtaylor , thanks again for your review last time around. I believe to have addressed your suggestions. Especially point (2), preventing selection of Stamen maps without a token, proved to be a bit of a challenge. Looking forward to hear/read what you think about it. |
This aims at providing a slightly more precise error in case the selected map type requires an API key and SatelliteEyes has not been provided with a valid key.
paulschuberth
force-pushed
the
allow-custom-tokens
branch
from
01d7013
to
da87d9b
Compare
|
Hey Paul, just wondering if this ever got merged into the main branch? |
|
Hey @NortonTech3D, not to my knowledge, no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all thank you for this fun application!
This PR goal is to resolve #76 by providing a user interface to provide an API key for the maps provided by Stamen/Stadia.
As of right now it's still pretty rough and will likely need some polishing. I am not familiar with the value bindings in
TTPreferencesWindow.xib. The current solution copies the approach of the other settings and hopes for the best. Maybe some form of validation is appropriate here?I am very much open to suggestions and ideas. My Obj-C got a bit rusty and I have so far not worked with AppKit.