Reference LICENSE file in .gemspec #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rubygems.org page shows that the license is unknown because it references the .gemspec file which omits the license metadata.
sue445
approved these changes
Apr 28, 2024
There was a problem hiding this comment.
thx!
I didn't know about LicenseRef, but after reading https://guides.rubygems.org/specification-reference/#license= I understand it.
|
This PR was originally released as v1.0.1, but due to some problems, this has been re-released as v.1.0.2. see #88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rubygems.org page shows that the license is unknown because it references the .gemspec file which omits the license metadata. When reviewing the licenses for a project, I noticed that the gem wasn't showing a license, even though the repo mentions it's MIT licensed. It's possible others are also running into this, so I've added the license-ref in the .gemspec file.