Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference LICENSE file in .gemspec #87

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

oatovar
Copy link
Contributor

@oatovar oatovar commented Apr 26, 2024

The rubygems.org page shows that the license is unknown because it references the .gemspec file which omits the license metadata. When reviewing the licenses for a project, I noticed that the gem wasn't showing a license, even though the repo mentions it's MIT licensed. It's possible others are also running into this, so I've added the license-ref in the .gemspec file.

The rubygems.org page shows that the license is unknown because
it references the .gemspec file which omits the license metadata.
@sue445 sue445 self-requested a review April 27, 2024 11:17
Copy link
Collaborator

@sue445 sue445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

I didn't know about LicenseRef, but after reading https://guides.rubygems.org/specification-reference/#license= I understand it.

@sue445 sue445 merged commit 23cf041 into tomykaira:master Apr 28, 2024
5 checks passed
@sue445 sue445 mentioned this pull request Apr 28, 2024
@sue445
Copy link
Collaborator

sue445 commented Apr 28, 2024

This PR was originally released as v1.0.1, but due to some problems, this has been re-released as v.1.0.2.

see #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants