Added ALG Rev A and other games to Rom Manager #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Rev A and derived games do not have working controls
|
I finally added roms and descramblers from your patch + my own model/revision detection (I didn't want to have extra models variables in common code) |
|
Great, I never got to the bottom of the inputs not working (it's like we're pulling them from the wrong mapped space) but feel free to take this wherever as I don't have anything else to add. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automatically sets Rev A for all games of the appropriate size and adjusts the NVRAM location accordingly.
TODO: Rev A and derived games do not have working controls (no Start buttons), even though reads look the same
Precise NVRAM location seems not possible in the current spec
(Rev A is 0xF54000 to 0xF55FFF, Rev B is 0xF7C000 to 0xF7DFFF)