Skip to content

Commit

Permalink
Fixed width issue #739 for real this time
Browse files Browse the repository at this point in the history
  • Loading branch information
tonsky committed Apr 5, 2019
1 parent 40e6086 commit 5cd26d3
Show file tree
Hide file tree
Showing 24 changed files with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,14 @@
source venv/bin/activate

# variable font
rm -rf distr/variable_ttf

This comment has been minimized.

Copy link
@thundernixon

thundernixon Apr 5, 2019

Contributor

Were the files not being overwritten by FontMake, already?

This comment has been minimized.

Copy link
@tonsky

tonsky Apr 5, 2019

Author Owner

I had an issue when they were autohinted later and appeared new, even though they weren’t. Anyways this is more reliable I guess

fontmake -g FiraCode.glyphs -o variable --output-dir distr/variable_ttf

# statics
fontmake -g FiraCode.glyphs -o ttf --output-dir distr/ttf
fontmake -g FiraCode.glyphs -o otf --output-dir distr/otf
rm -rf distr/ttf
fontmake -g FiraCode.glyphs -o ttf --output-dir distr/ttf -i

This comment has been minimized.

Copy link
@thundernixon

thundernixon Apr 5, 2019

Contributor

What does the -i do, here? From the FontMake --help docs:

-i [INSTANCE_NAME], --interpolate [INSTANCE_NAME]
Interpolate masters and generate all the instances
defined. To only interpolate a specific instance (or
instances) that match a given "name" attribute, you
can pass as argument the full instance name or a
regular expression. E.g.: -i "Noto Sans Bold"; or -i
".* UI Condensed". (for Glyphs or MutatorMath sources
only).

...but you haven't included a specific regex pattern here for it to match, so I'm curious whether it does anything.

This comment has been minimized.

Copy link
@tonsky

tonsky via email Apr 5, 2019

Author Owner

This comment has been minimized.

Copy link
@thundernixon

thundernixon Apr 5, 2019

Contributor

Oh woah! 🤭

I was so focused on the variable font, I totally missed that. What a strange default setting on FontMake, for statics...

Very good catch; thank you! I'll update my google/fonts PR with the fresh statics.

rm -rf distr/otf
fontmake -g FiraCode.glyphs -o otf --output-dir distr/otf -i

# ============================================================================
# Autohinting ================================================================
Expand Down
Binary file modified distr/otf/FiraCode-Bold.otf
Binary file not shown.
Binary file modified distr/otf/FiraCode-Light.otf
Binary file not shown.
Binary file modified distr/otf/FiraCode-Medium.otf
Binary file not shown.
Binary file modified distr/otf/FiraCode-Regular.otf
Binary file not shown.
Binary file modified distr/otf/FiraCode-Retina.otf
Binary file not shown.
Binary file modified distr/ttf/FiraCode-Bold.ttf
Binary file not shown.
Binary file modified distr/ttf/FiraCode-Light.ttf
Binary file not shown.
Binary file modified distr/ttf/FiraCode-Medium.ttf
Binary file not shown.
Binary file modified distr/ttf/FiraCode-Regular.ttf
Binary file not shown.
Binary file modified distr/ttf/FiraCode-Retina.ttf
Binary file not shown.
Binary file modified distr/variable_ttf/FiraCode-VF.ttf
Binary file not shown.
Binary file modified distr/woff/FiraCode-Bold.woff
Binary file not shown.
Binary file modified distr/woff/FiraCode-Light.woff
Binary file not shown.
Binary file modified distr/woff/FiraCode-Medium.woff
Binary file not shown.
Binary file modified distr/woff/FiraCode-Regular.woff
Binary file not shown.
Binary file modified distr/woff/FiraCode-Retina.woff
Binary file not shown.
Binary file modified distr/woff/FiraCode-VF.woff
Binary file not shown.
Binary file modified distr/woff2/FiraCode-Bold.woff2
Binary file not shown.
Binary file modified distr/woff2/FiraCode-Light.woff2
Binary file not shown.
Binary file modified distr/woff2/FiraCode-Medium.woff2
Binary file not shown.
Binary file modified distr/woff2/FiraCode-Regular.woff2
Binary file not shown.
Binary file modified distr/woff2/FiraCode-Retina.woff2
Binary file not shown.
Binary file modified distr/woff2/FiraCode-VF.woff2
Binary file not shown.

0 comments on commit 5cd26d3

Please sign in to comment.