Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation save order #80

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Installation save order #80

merged 1 commit into from
Apr 23, 2024

Conversation

tbinna
Copy link
Member

@tbinna tbinna commented Apr 23, 2024

  • Update the order in which installation payloads are saved by first saving the tenant and only then saving the Forge installation

@tbinna tbinna force-pushed the fix/save-installation-order branch from 9d550e9 to 44123a2 Compare April 23, 2024 10:50
- Update the order in which installation payloads are saved by first saving the tenant and only then saving the Forge installation
@tbinna tbinna force-pushed the fix/save-installation-order branch from 44123a2 to 95d390a Compare April 23, 2024 11:17
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.84%. Comparing base (b5fb51e) to head (95d390a).

Files Patch % Lines
...ssian/connect/play/services/LifecycleService.scala 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   85.49%   86.84%   +1.34%     
==========================================
  Files          24       24              
  Lines         262      266       +4     
  Branches        8        9       +1     
==========================================
+ Hits          224      231       +7     
+ Misses         38       35       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tbinna tbinna merged commit ed1ef9b into master Apr 23, 2024
5 checks passed
@mergify mergify bot deleted the fix/save-installation-order branch April 23, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant