Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forge Remote #81

Merged
merged 1 commit into from
May 22, 2024
Merged

Forge Remote #81

merged 1 commit into from
May 22, 2024

Conversation

tbinna
Copy link
Member

@tbinna tbinna commented May 14, 2024

  • Add JWT validation library to project dependencies
  • Add ForgeRemoteSignedForgeRemoteContextAction to verify Forge Remote requests
  • Add action refiners and helper classes to extract and validate Forge Remote context and JWTs
  • Add tests for new code

fixes #76

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 86.94%. Comparing base (96fbd7e) to head (00caf9b).

Files Patch % Lines
...ic/ForgeRemoteSignedForgeRemoteContextAction.scala 50.00% 4 Missing ⚠️
...auth/frc/jwt/ForgeJWSVerificationKeySelector.scala 80.00% 2 Missing ⚠️
.../asymmetric/AssociateAtlassianHostUserAction.scala 95.23% 1 Missing ⚠️
...c/SymmetricallySignedAtlassianHostUserAction.scala 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   84.96%   86.94%   +1.98%     
==========================================
  Files          24       32       +8     
  Lines         266      360      +94     
  Branches        9        9              
==========================================
+ Hits          226      313      +87     
- Misses         40       47       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tbinna tbinna force-pushed the feature/forge-remote branch 3 times, most recently from 33dbf30 to b6cd762 Compare May 15, 2024 08:35
- Add JWT validation library to project dependencies
- Add ForgeRemoteSignedForgeRemoteContextAction to verify Forge Remote requests
- Add action refiners and helper classes to extract and validate Forge Remote context and JWTs
- Add `AtlassianHostUserRequest` abstraction because we now have host-user request from Connect and host-user requests from Forge
- Add tests for new code

fixes #76
@tbinna tbinna merged commit 9cf7441 into master May 22, 2024
5 checks passed
@tbinna tbinna deleted the feature/forge-remote branch May 22, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forge Remote
1 participant