Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move static functions outside of class definition #20

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

topherinternational
Copy link
Owner

All static or static-eligible methods (methods that don't reference the self argument) have been moved out of the checker classes and up to the module level. This enhances the functions' testability and makes the checker class code easier to read as they now only contain visitor methods or methods that compute message criteria and add messages.

@topherinternational topherinternational merged commit 46abc00 into main Dec 21, 2023
2 checks passed
@topherinternational topherinternational deleted the move-more-functions branch December 21, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant