Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix $RECOVERYMODE from config being incorrectly overridden #7381

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

canyie
Copy link
Collaborator

@canyie canyie commented Sep 24, 2023

Move legacy SAR checking logic into mount_partitions, and avoid calling get_flags before check_boot_ramdisk
Fix #7346

Move legacy SAR checking logic into mount_partitions, and avoid calling get_flags before check_boot_ramdisk
Fix topjohnwu#7346
@pndwal
Copy link
Contributor

pndwal commented Sep 25, 2023

Many thanks Devs! ... Despite my misunderstanding workings, this seems to be a proper/working fix. 👍

@osm0sis osm0sis added app This issue is related to Magisk App core This issue is related to Magisk Core labels Oct 8, 2023
@topjohnwu topjohnwu merged commit 187f583 into topjohnwu:master Oct 10, 2023
8 checks passed
@canyie canyie deleted the recmode branch October 11, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app This issue is related to Magisk App core This issue is related to Magisk Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App loses Recovery mode user setting for A-only legacy SAR devices
4 participants