Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rips persistence diagram #1005

Merged
merged 17 commits into from
Feb 2, 2024

Conversation

MClemot
Copy link
Contributor

@MClemot MClemot commented Jan 30, 2024

This PR introduces the RipsPersistenceDiagram module. It computes the persistence diagram of the Rips complex of an input point cloud or distance matrix, using the Ripser implementation as backend.

Copy link
Collaborator

@julien-tierny julien-tierny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Matteo,
thanks a lot for your PR!
could you please address the handful of low-level detail remarks I entered in this review? thanks!

@julien-tierny
Copy link
Collaborator

alright, that's all good!
may that PR be the first of many :)

@julien-tierny julien-tierny merged commit cd1ce59 into topology-tool-kit:dev Feb 2, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants